Fix serialization issue #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinRenou
force-pushed
the
serialization_issue
branch
2 times, most recently
from
cc2c3d0 to
61e0972
Compare
Signed-off-by: martinRenou <martin.renou@gmail.com>
martinRenou
force-pushed
the
serialization_issue
branch
from
61e0972 to
9e3b226
Compare
martinRenou
commented
Mar 4, 2022
| @@ -336,14 +348,17 @@ class DataGrid(DOMWidget): | |||
| selection_mode = Enum( | |||
| default_value="none", values=["row", "column", "cell", "none"] | |||
| ).tag(sync=True) | |||
| selections = List(Dict()).tag(sync=True, **widget_serialization) | |||
There was a problem hiding this comment.
I'm removing the widgets serializer here, we don't need it as it's a simple dictionary?
| auto_fit_columns = Bool(False).tag(sync=True) | ||
| auto_fit_params = Dict( | ||
| {"area": "all", "padding": 30, "numCols": None}, allow_none=False | ||
| ).tag(sync=True, **widget_serialization) |
ibdafna
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
renderersserialization was not returning valid JSON, this PR fixes it