Skip to content

Commit

Permalink
Remove prepublish script
Browse files Browse the repository at this point in the history
  • Loading branch information
@martinRenou
martinRenou committed Mar 3, 2021
1 parent 636e05e commit 81e125e
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions js/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@
"scripts": {
"build": "webpack && npm run build:labextension",
"build:labextension": "jupyter labextension build .",
"clean": "rimraf dist/ && rimraf ../ipytree/labextension/ && rimraf ../ipytree/nbextension",
"prepublish": "npm run clean && npm run build"
"clean": "rimraf dist/ && rimraf ../ipytree/labextension/ && rimraf ../ipytree/nbextension"
},
"devDependencies": {
"@jupyterlab/builder": "^3.0.0",
Expand Down

2 comments on commit 81e125e

@tylere
Copy link

@tylere tylere commented on 81e125e Aug 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you comment on why the "prepublish" step was removed?
This appears to be the reason the dist/ folder is missing (issue #57), and ipytree does not work in Colab.

@martinRenou
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure this is the reason, other widgets packages don't have a prepublish and they work fine. I probably did something wrong while releasing. Hopefully next release will fix this (it's coming soon with ipywidgets 8 support). Sorry for the long wait on ipytree.

Please sign in to comment.