Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the test suite prettier, add coverage #14

Closed
3 of 4 tasks
parente opened this issue Oct 13, 2015 · 2 comments
Closed
3 of 4 tasks

Make the test suite prettier, add coverage #14

parente opened this issue Oct 13, 2015 · 2 comments
Assignees
Milestone

Comments

@parente
Copy link
Contributor

parente commented Oct 13, 2015

I'm not spending many cycles on keeping the test suite beautiful at the moment. Tracking warts here.

  • split into multiple modules, not one giant test_gatewayapp module; tests for the jupyter-websocket mode vs the notebook-http mode are a first order candidate for a split
  • try to fix the hangs on travis (not fixed, but rather opened upstream Travis stalls after tests succeed #94)
  • some test cases are not checking all endpoints when they should be; fix these using loops or by making explicit calls to all endpoints.
  • enable code coverage report
@parente parente self-assigned this Jan 25, 2016
parente added a commit that referenced this issue Jan 25, 2016
[issue #14] Separate notebook-http and jupyter-websocket tests
@parente parente changed the title Make the test suite prettier Make the test suite prettier, add coverage Feb 15, 2016
@parente parente modified the milestone: 0.5.0 Mar 3, 2016
@parente
Copy link
Contributor Author

parente commented Mar 15, 2016

We've been slowly adding additional endpoint checks as we go. I don't think we need to expend a ton of effort on making sure every single option / endpoint is tested at the moment.

I'll enable test coverage stats next.

@parente
Copy link
Contributor Author

parente commented Mar 17, 2016

Coverage stats look fine. Closing.

@parente parente closed this as completed Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant