Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up license #77

Merged
merged 2 commits into from
Feb 17, 2023
Merged

Clean up license #77

merged 2 commits into from
Feb 17, 2023

Conversation

dcsaba89
Copy link
Contributor

@blink1073, same change as the below PRs for jupyter-client for which now the package's license is perfectly recognized by github as well

jupyter/jupyter_client#934

please approve

@welcome
Copy link

welcome bot commented Feb 16, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 84.58% // Head: 84.58% // No change to project coverage 👍

Coverage data is based on head (755dbeb) compared to base (afb9478).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #77   +/-   ##
=======================================
  Coverage   84.58%   84.58%           
=======================================
  Files           7        7           
  Lines         227      227           
  Branches       37       37           
=======================================
  Hits          192      192           
  Misses         25       25           
  Partials       10       10           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 changed the title add license Clean up license Feb 17, 2023
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit ee57e90 into jupyter-server:main Feb 17, 2023
@welcome
Copy link

welcome bot commented Feb 17, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants