Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Server Version Handling and Clean up CI #71

Merged
merged 4 commits into from
Dec 18, 2022

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented Dec 17, 2022

@blink1073 blink1073 enabled auto-merge (squash) December 17, 2022 23:19
@codecov
Copy link

codecov bot commented Dec 17, 2022

Codecov Report

Base: 82.57% // Head: 85.52% // Increases project coverage by +2.95% 🎉

Coverage data is based on head (7d6b581) compared to base (2a489a8).
Patch coverage: 82.35% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   82.57%   85.52%   +2.95%     
==========================================
  Files           7        7              
  Lines         241      228      -13     
  Branches       37       38       +1     
==========================================
- Hits          199      195       -4     
+ Misses         33       23      -10     
- Partials        9       10       +1     
Impacted Files Coverage Δ
jupyter_server_terminals/__init__.py 50.00% <40.00%> (ø)
jupyter_server_terminals/api_handlers.py 100.00% <100.00%> (+3.84%) ⬆️
jupyter_server_terminals/app.py 75.51% <100.00%> (+2.43%) ⬆️
jupyter_server_terminals/base.py 100.00% <100.00%> (+25.00%) ⬆️
jupyter_server_terminals/handlers.py 77.77% <100.00%> (+3.41%) ⬆️
jupyter_server_terminals/terminalmanager.py 88.75% <100.00%> (+2.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 merged commit b1f2a99 into jupyter-server:main Dec 18, 2022
@blink1073 blink1073 deleted the fix-ci branch December 18, 2022 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant