Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set terminals_available to False when not enabled #105

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

Wh1isper
Copy link
Contributor

@Wh1isper Wh1isper commented Jan 10, 2024

Suggested by @lp9052 in #85 (comment)

by looking at the source code, it does respect the terminal config.

However, I believe it should update termina_avaliable to False instead of just return.

nbclassic actually read this field and will fail to launch if the value is missing.

I know they should have a default value for missing fields(issue raised). But I also believe it should be populated, instead of just missing.

Link to nbclassic issue: jupyter/nbclassic#255

this allows us to be consistent with Jupyter Server 1.x behaviour: https://github.com/jupyter-server/jupyter_server/blob/1.x/jupyter_server/serverapp.py#L363

@Wh1isper Wh1isper changed the title Set terminals_available False when not enabled Set terminals_available to False when not enabled Jan 10, 2024
@Wh1isper
Copy link
Contributor Author

@blink1073 Can you take a look at your convenience?

@blink1073 blink1073 added the bug Something isn't working label Jan 22, 2024
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit d289632 into jupyter-server:main Jan 22, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants