Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support OPTIONS method for CORS #102

Merged
merged 1 commit into from
Dec 26, 2023
Merged

fix: support OPTIONS method for CORS #102

merged 1 commit into from
Dec 26, 2023

Conversation

zhanba
Copy link
Contributor

@zhanba zhanba commented Dec 22, 2023

No description provided.

@welcome Welcome
Copy link

welcome bot commented Dec 22, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@zhanba
Copy link
Contributor Author

zhanba commented Dec 25, 2023

@blink1073 can you review this pr?

blink1073
blink1073 approved these changes Dec 26, 2023
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 added the bug Something isn't working label Dec 26, 2023
@blink1073 blink1073 merged commit 58ad66a into jupyter-server:main Dec 26, 2023
23 of 24 checks passed
@welcome Welcome
Copy link

welcome bot commented Dec 26, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@zhanba zhanba deleted the fix-cors branch January 1, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhanba @blink1073