Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make preferred_dir content manager trait #983

Merged
merged 6 commits into from
Dec 8, 2022
Merged

Make preferred_dir content manager trait #983

merged 6 commits into from
Dec 8, 2022

Commits on Dec 8, 2022

  1. fix terminal test on Windows

    @vidartf
    vidartf committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    37bba4c View commit details
    Browse the repository at this point in the history

  2. Make preferred_dir content manager trait 

    Move the preferred_dir trait to content manager, but keep the old one for backwards compatibility. The new location should also cause the value to be read later in the init, allowing us to avoid the deferred validation. Also fixes an issue with escaping the root dir on Windows if an absolute path is passed.
    @vidartf
    vidartf committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    70f65a2 View commit details
    Browse the repository at this point in the history

  3. Remove leading "/" from preferred_dir 

    Also validates set value to strip any leading slashes
    @vidartf
    vidartf committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    eb31253 View commit details
    Browse the repository at this point in the history

  4. Allow filemanager to have OS path set 

    Will transparently convert to API path in validator.
    @vidartf
    vidartf committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    c8e4ede View commit details
    Browse the repository at this point in the history

  5. fix mypy

    @vidartf
    vidartf committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    7a14af1 View commit details
    Browse the repository at this point in the history

  6. fix ruff

    @vidartf
    vidartf committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    5fffaf7 View commit details
    Browse the repository at this point in the history