Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Batch 1] Port Notebook PRs #95

Merged
merged 8 commits into from
Sep 25, 2019
Merged

[Batch 1] Port Notebook PRs #95

merged 8 commits into from
Sep 25, 2019

Commits on Sep 25, 2019

  1. properly handle unicode characters in home dirs

    @vit-tucek @Zsailer
    vit-tucek authored and Zsailer committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    11044cc View commit details
    Browse the repository at this point in the history

  2. flush iopub before sending restarting/dead status messages 

    to ensure (approximately) that all messages from the stopped kernel are delivered before the dead/restarting message
    @minrk @Zsailer
    minrk authored and Zsailer committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    a80d7f0 View commit details
    Browse the repository at this point in the history

  3. [FIX] notebookapp, auth: get_secure_cookie kwargs 

    Per Tornado's documentation:

>By default, Tornado’s secure cookies expire after 30 days.
>To change this, use the expires_days keyword argument to
>set_secure_cookie and the max_age_days argument to get_secure_cookie.
>These two values are passed separately so that you may
>e.g. have a cookie that is valid for 30 days for most purposes,
>but for certain sensitive actions
>(such as changing billing information)
>you use a smaller max_age_days when reading the cookie.

With the current implementation in `auth/login.py`,
this is possible to pass the `expires_days` option
but not possible to enforce it as this is not possible
to pass `max_age_days` to `get_secure_cookie`

This makes impossible to set the cookie expiration without
using a custom `LoginHandler`.

This revision is about adding the possibility to pass options
to Tornado's `get_secure_cookie` method,
so it can be possible to set the cookies expiration,
among others.
    @beledouxdenis @Zsailer
    beledouxdenis authored and Zsailer committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    cd79a98 View commit details
    Browse the repository at this point in the history

  4. ip_address only accepts unicode on Python 2 

    ipaddress.ip_address('127.0.0.1') fails with ValueError on Python 2

need to decode it, otherwise 127.0.0.1 won't be treated as local
    @minrk @Zsailer
    minrk authored and Zsailer committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    349045e View commit details
    Browse the repository at this point in the history

  5. use localhost as default local hostname 

    so this list isn't empty when these handlers are used outside NotebookApp
    @minrk @Zsailer
    minrk authored and Zsailer committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    b145196 View commit details
    Browse the repository at this point in the history

  6. Make the max_body_size & max_buffer_size configurable

    @mociarain @Zsailer
    mociarain authored and Zsailer committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    c09c9d6 View commit details
    Browse the repository at this point in the history

  7. Correctly pass them to the underlying tornado server

    @mociarain @Zsailer
    mociarain authored and Zsailer committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    256b288 View commit details
    Browse the repository at this point in the history

  8. Fix quotes and tidy up the help messages

    @mociarain @Zsailer
    mociarain authored and Zsailer committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    f214666 View commit details
    Browse the repository at this point in the history