-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Batch 1] Port Notebook PRs #95
Merged
Merged
Commits on Sep 25, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 11044cc - Browse repository at this point
Copy the full SHA 11044ccView commit details -
flush iopub before sending restarting/dead status messages
to ensure (approximately) that all messages from the stopped kernel are delivered before the dead/restarting message
Configuration menu - View commit details
-
Copy full SHA for a80d7f0 - Browse repository at this point
Copy the full SHA a80d7f0View commit details -
[FIX] notebookapp, auth:
get_secure_cookie
kwargsPer Tornado's documentation: >By default, Tornado’s secure cookies expire after 30 days. >To change this, use the expires_days keyword argument to >set_secure_cookie and the max_age_days argument to get_secure_cookie. >These two values are passed separately so that you may >e.g. have a cookie that is valid for 30 days for most purposes, >but for certain sensitive actions >(such as changing billing information) >you use a smaller max_age_days when reading the cookie. With the current implementation in `auth/login.py`, this is possible to pass the `expires_days` option but not possible to enforce it as this is not possible to pass `max_age_days` to `get_secure_cookie` This makes impossible to set the cookie expiration without using a custom `LoginHandler`. This revision is about adding the possibility to pass options to Tornado's `get_secure_cookie` method, so it can be possible to set the cookies expiration, among others.
Configuration menu - View commit details
-
Copy full SHA for cd79a98 - Browse repository at this point
Copy the full SHA cd79a98View commit details -
ip_address only accepts unicode on Python 2
ipaddress.ip_address('127.0.0.1') fails with ValueError on Python 2 need to decode it, otherwise 127.0.0.1 won't be treated as local
Configuration menu - View commit details
-
Copy full SHA for 349045e - Browse repository at this point
Copy the full SHA 349045eView commit details -
use localhost as default local hostname
so this list isn't empty when these handlers are used outside NotebookApp
Configuration menu - View commit details
-
Copy full SHA for b145196 - Browse repository at this point
Copy the full SHA b145196View commit details -
Configuration menu - View commit details
-
Copy full SHA for c09c9d6 - Browse repository at this point
Copy the full SHA c09c9d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 256b288 - Browse repository at this point
Copy the full SHA 256b288View commit details -
Configuration menu - View commit details
-
Copy full SHA for f214666 - Browse repository at this point
Copy the full SHA f214666View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.