avoid creating asyncio.Lock at import time #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asyncio.Lock references the current event loop. There usually isn't one at import time. Instead, create lock and attach it to the Handler class upon initializing the first handler of the class
minrk
commented
Jul 29, 2022
| for exporter_name in exporters: | ||
| try: | ||
| async with LOCK: | ||
| async with self._exporter_lock: |
There was a problem hiding this comment.
Moved acquisition of the lock outside the loop so we aren't acquiring and re-acquiring the same lock for each exporter.
Codecov Report
@@ Coverage Diff @@
## main #935 +/- ##
==========================================
- Coverage 72.26% 72.20% -0.06%
==========================================
Files 65 65
Lines 7997 8002 +5
Branches 1335 1333 -2
==========================================
- Hits 5779 5778 -1
- Misses 1811 1814 +3
- Partials 407 410 +3
Continue to review full report at Codecov.
|
|
@meeseeksdev please backport to 1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyter_server
that referenced
this pull request
Jul 29, 2022
blink1073
pushed a commit
that referenced
this pull request
Jul 29, 2022
Co-authored-by: Min RK <benjaminrk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asyncio.Lock references the current event loop, but there usually isn't one at import time. The result is that importing this handler always instantiates a current loop and attaches a lock to it, which may or may not be the loop that ultimately runs (app.io_loop).
Instead, create lock and attach it to the Handler class upon initializing the first handler of the class, which is always run inside the loop.
Also related to #876