Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get_kernel_path for AsyncFileManagers. #929

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Fix get_kernel_path for AsyncFileManagers. #929

merged 1 commit into from
Jul 19, 2022

Conversation

thetorpedodog
Copy link
Contributor

Since AsyncFileManager never overrode get_kernel_path, the base
(synchronous) implementation would call self.dir_exists and get back
a coroutine (which always evaluates as true), but never await it.

@thetorpedodog
Fix get_kernel_path for AsyncFileManagers.
ce7264c 
Since `AsyncFileManager` never overrode `get_kernel_path`, the base
(synchronous) implementation would call `self.dir_exists` and get back
a coroutine (which always evaluates as true), but never await it.
@thetorpedodog
Copy link
Contributor Author

@kevin-bates I vaguely remember reading somewhere that there was a way to get one of the Meeseeks to add a label to a PR with a special @ request in the description or a comment, but I can’t find where that documentation was. Do you know what it is?

@kevin-bates
Copy link
Member

Hi @thetorpedodog. I'm not very familiar with the Meeseeks bot world. I've used MeeseeksDev to transfer issues between organizations, but that's about it.

I just reproduced the issue you're resolving and trying out your fix now. Great catch, and thank you for the contribution!

kevin-bates
kevin-bates approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good - thank you @thetorpedodog.

@thetorpedodog
Copy link
Contributor Author

Thanks for the quick review!

@kevin-bates kevin-bates mentioned this pull request Jul 19, 2022
Open
@Zsailer Zsailer merged commit eb9bf30 into jupyter-server:main Jul 19, 2022
@thetorpedodog
Copy link
Contributor Author

@meeseeksdev please backport to 1.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jul 19, 2022

Awww, sorry thetorpedodog you do not seem to be allowed to do that, please ask a repository maintainer.

@thetorpedodog
Copy link
Contributor Author

aw beans

@Zsailer
Copy link
Member

Zsailer commented Jul 19, 2022

@meeseeksdev please backport to 1.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jul 19, 2022

Something went wrong ... Please have a look at my logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zsailer Zsailer Zsailer approved these changes

@kevin-bates kevin-bates kevin-bates approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thetorpedodog @kevin-bates @Zsailer