-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable GatewayClient managers to be configurable #834
Conversation
Codecov Report
@@ Coverage Diff @@
## main #834 +/- ##
==========================================
+ Coverage 70.05% 70.10% +0.04%
==========================================
Files 63 63
Lines 7548 7559 +11
Branches 1258 1260 +2
==========================================
+ Hits 5288 5299 +11
Misses 1880 1880
Partials 380 380
Continue to review full report at Codecov.
|
This is ready for review. I think we should backport this PR once merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and seems like a useful change. Thanks @Zsailer!
@meeseeksdev please backport to 1.x |
If GatewayClient is enabled, it hardcodes the session_manager, kernel_manager, and kernelspec_manager. I think we still want these classes to be overridable. This PR keeps the defaults the same (backwards compatible) while also allowing it to be configurable.