-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the root_dir value to the logging message in case of non compliant preferred_dir #804
Add the root_dir value to the logging message in case of non compliant preferred_dir #804
Conversation
It looks like a couple tests need to be updated with the new text. |
Codecov Report
@@ Coverage Diff @@
## main #804 +/- ##
=======================================
Coverage 69.96% 69.96%
=======================================
Files 62 62
Lines 7368 7368
Branches 1223 1223
=======================================
Hits 5155 5155
Misses 1841 1841
Partials 372 372
Continue to review full report at Codecov.
|
@blink1073 Thx for the review. CI is now green (except 1 failure not relevant to this PR). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@meeseeksdev please backport to 1.x |
… message in case of non compliant preferred_dir
Thx @blink1073 The backport PR is #804 |
… message in case of non compliant preferred_dir) (#805) Co-authored-by: Eric Charles <eric@datalayer.io>
Fixes #803