Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init_httpserver at the end of initialize #517

Merged
merged 1 commit into from
May 13, 2021
Merged

init_httpserver at the end of initialize #517

merged 1 commit into from
May 13, 2021

Commits on May 13, 2021

  1. init_httpserver at the end of initialize 

    init_httpserver references IOLoop.current()

If a server extension sets an asyncio EventLoopPolicy, any prior reference to IOLoop.current or asyncio.get_event_loop() will be invalidated.

We should try to avoid this during intialize at all, or at least until the very end.

Arguably, the http server listen should occur in `.start()`
    @minrk
    minrk committed May 13, 2021
    Configuration menu
    Copy the full SHA
    9cf60d9 View commit details
    Browse the repository at this point in the history