Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make nbconvert root handler asynchronous #512

Merged
merged 1 commit into from
May 7, 2021
Merged

Make nbconvert root handler asynchronous #512

merged 1 commit into from
May 7, 2021

Conversation

hMED22
Copy link

@hMED22 hMED22 commented May 7, 2021 •
edited
Loading

Resolves #490.

@welcome
Copy link

welcome bot commented May 7, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@blink1073 blink1073 added this to the 1.7 milestone May 7, 2021
mwakaba2
mwakaba2 approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@mwakaba2 mwakaba2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@blink1073 blink1073 merged commit 3927d28 into jupyter-server:master May 7, 2021
Zsailer
Zsailer approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hMED22 and @mwakaba2. 🚀

@welcome
Copy link

welcome bot commented May 7, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@hMED22 hMED22 deleted the make-nbconvert-root-handler-asynchronous branch May 7, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zsailer Zsailer Zsailer approved these changes

@mwakaba2 mwakaba2 mwakaba2 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

nbconvert handler is affected by slow filesystems and blocks event loop
4 participants
@hMED22 @Zsailer @mwakaba2 @blink1073