Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Appropriate Token Permission for CodeQL Workflow #489

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Add Appropriate Token Permission for CodeQL Workflow #489

merged 1 commit into from
Apr 22, 2021

Conversation

afshin
Copy link
Contributor

@afshin afshin commented Apr 22, 2021

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2021

Codecov Report

Merging #489 (265abd2) into master (d3b40f4) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
- Coverage   77.81%   77.73%   -0.09%     
==========================================
  Files         106      106              
  Lines        9269     9269              
  Branches      997      997              
==========================================
- Hits         7213     7205       -8     
- Misses       1702     1707       +5     
- Partials      354      357       +3     
Impacted Files Coverage Δ
jupyter_server/tests/services/kernels/test_api.py 97.05% <0.00%> (-1.97%) ⬇️
jupyter_server/services/kernels/handlers.py 61.37% <0.00%> (-1.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3b40f4...265abd2. Read the comment docs.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and analogous to that done in lab.

@blink1073 blink1073 added this to the 1.6 milestone Apr 22, 2021
@blink1073 blink1073 merged commit 6a3fc57 into jupyter-server:master Apr 22, 2021
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Add Appropriate Token Permission for CodeQL Workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants