-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor gateway kernel management to achieve a degree of consistency #483
Refactor gateway kernel management to achieve a degree of consistency #483
Conversation
cc @declanvk |
Codecov Report
@@ Coverage Diff @@
## master #483 +/- ##
==========================================
- Coverage 77.78% 77.06% -0.73%
==========================================
Files 106 107 +1
Lines 9296 9487 +191
Branches 1003 1026 +23
==========================================
+ Hits 7231 7311 +80
- Misses 1705 1807 +102
- Partials 360 369 +9
Continue to review full report at Codecov.
|
This one needs a rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…ay-km Refactor gateway kernel management to achieve a degree of consistency
Issue #455 correctly points out an inconsistency between the
GatewayKernelManager
vs the otherMappingKernelManager
instances within the server in that itsget_kernel()
method doesn't return aKernelManager
instance, but rather a JSON object which corresponds to the model returned from the configured Gateway Server that corresponds the targeted kernel manager.This pull request introduces both a
GatewayKernelManager
(renaming the previous GKM toGatewayMappingKernelManager
) and aGatewayKernelClient
class that essentially proxy all requests (and responses) to (from) the configured Gateway Server instance.It should be noted that these proxy objects do not support the full functionality of regular
KernelManager
andKernelClient
instances but strive to address a certain degree of usability to accomplish a resemblance of consistency across kernel manager/client instances.Resolves #455
(Note: the renaming of the gateway mapping kernel manager is not a compatibility issue because subclassing is currently not supported.)