Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use async kernel manager by default #399

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

kevin-bates
Copy link
Member

Seems time we switched to using the async kernel management framework by default. This has already been adopted by NBclient (Papermill), Voila, and Enterprise Gateway.

@codecov-io
Copy link

codecov-io commented Feb 3, 2021

Codecov Report

Merging #399 (9035592) into master (5013f62) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #399      +/-   ##
==========================================
- Coverage   68.87%   68.85%   -0.02%     
==========================================
  Files          57       57              
  Lines        6319     6319              
  Branches      846      846              
==========================================
- Hits         4352     4351       -1     
  Misses       1678     1678              
- Partials      289      290       +1     
Impacted Files Coverage Δ
jupyter_server/serverapp.py 60.09% <ø> (ø)
jupyter_server/gateway/managers.py 77.58% <100.00%> (ø)
jupyter_server/services/kernels/handlers.py 58.24% <0.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5013f62...9035592. Read the comment docs.

@Zsailer Zsailer merged commit 122d93a into jupyter-server:master Feb 3, 2021
Zsailer pushed a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants