Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manager.py: more descriptive warnings when extensions fail to load #396

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

alberti42
Copy link
Contributor

Warning message are descriptive when an extension fails to load. To provide an example, before this tiny fix, I got the warning message when starting jupyter-lab:
[W 2021-01-29 16:36:12.766 ServerApp] 'nbextensions_path'
while now I would get:
[W 2021-01-29 16:55:35.576 ServerApp] jupyter_nbextensions_configurator | extension failed loading with message: 'nbextensions_path'
clarifying that it is jupyter_nbextensions_configurator not loading. With this better description, this warning is no more surprising because I know that this extension is for the classic notebook only.

Made warning message when an extension fails to load more descriptive to avoid puzzling the user about what is going on
Copy link
Member

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @alberti42. This is great!

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @Zsailer - this is very useful. So much so, I was hoping you could do the same for the link and add methods. 😄 🙏

Also, while we're in this file, would it be possible to make a quick pass to convert the log statements to use f-strings? Aside from those in these methods, there are just a couple other raise statements near the top that would require modification.

I think it would be good to start converting these when we can.

@Zsailer
Copy link
Member

Zsailer commented Feb 18, 2021

Since there hasn't been activity on this PR for a few weeks, I suggest we merge as-is and address @kevin-bates's suggestions in later PRs.

@Zsailer Zsailer merged commit bf36ab5 into jupyter-server:master Feb 18, 2021
Zsailer added a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Update manager.py: more descriptive warnings when extensions fail to load
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants