Prevent missing IOPub on restart #358
Conversation
SylvainCorlay
force-pushed
the
missing-iopub-on-restart
branch
4 times, most recently
from
449079e
to
238d8fe
Compare
There was a problem hiding this comment.
After changing on_reply to on_shell_reply, I see the same behavior between server and notebook - restarts are not completing. I also notice that multiple SIGINT (ctrl-c) requests are not terminating the server and must issue a SIGQUIT (ctrl-) for the process to be terminated while in this state.
|
I'm sorry. It just dawned on me that this PR requires jupyter/jupyter_client#593, so please disregard the restart failure behavior. I'll need to pull that PR as well. |
SylvainCorlay
force-pushed
the
missing-iopub-on-restart
branch
from
238d8fe
to
eb71bb3
Compare
|
Thanks, I will continue the work on jupyter/notebook#5904. and only update this one when it gets in there. Basically, next change is to make the nudge loop an async thing. |
Actually it does not require jupyter/jupyter_client#593. Essentially, every client will need to nudge the kernel with kernel info requests until it gets something on iopub to guarantee that everything is connected. Discussion at jupyter/jupyter_client#593 |
|
Closing. Another approach coming up. |
|
I think the other approach mentioned above is #361... |
This is the jupyter_server flavor of jupyter/notebook#5904.
Related to jupyter/jupyter_client#593