Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken base_url traitlets config #280

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Aug 21, 2020

Fixes #278.

The value returned by the get_path method in ServerApp was creating a duplicate path by combining default_url and base_url. Default_url already includes the base url, so we shouldn't be joining these two paths.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 50856f5 into jupyter-server:master Aug 21, 2020
@blink1073 blink1073 added this to the 1.0 Release milestone Sep 17, 2020
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
@Zsailer Zsailer deleted the base_url-fix branch January 16, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure Base URL configuration is working
2 participants