Handle newer jupyter_events wants string version, drop 3.8 #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carreau
force-pushed
the
events-011
branch
2 times, most recently
from
f28457f to
0e3401c
Compare
Carreau
changed the title
|
Yeahhh all tests are passing. Obviously this is way bigger than I hopped. |
|
Looks like this could be released in a |
|
Great work, thanks! |
|
Thanks ! |
|
published 2.15.0 with this |
|
Thanks @minrk! |
|
thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Jupyter_events that deals with python-json-logger issue also fixed and issue where version should be string (as it can have minor versions like 1.1 for example).
The new Jupyter_events does not have support for python 3.8, so drop it as well; and propagate all the type changes.