Fix chunked file upload #1464
Open
Fix chunked file upload #1464
+19
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jupyter has manual upload system instead of using a standard form-multipart upload.
In the browser we manually chunk and upload files via separate PUT requests, and then in the code referenced in this PR, we save those chunks from the separate requests.
A significant issue is that requests can be lost or out of order, making the uploader fundamentally untrustworthy, but that isn't the focus of the PR.
There is a bug currently where files being uploaded with more than one chunk are only saving the last chunk, I've found this is due to overwriting after receiving each chunk, instead of appending.
This PR fixes that bug by adding a separate append function.