Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation note for ServerApp.preferred_dir #1396

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Add deprecation note for ServerApp.preferred_dir #1396

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22f460a
Add deprecation note
krassowski Feb 15, 2024
fafb014
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion jupyter_server/serverapp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1740,7 +1740,9 @@ def _root_dir_changed(self, change: t.Any) -> None:

preferred_dir = Unicode(
config=True,
help=trans.gettext("Preferred starting directory to use for notebooks and kernels."),
help=trans.gettext(
"Preferred starting directory to use for notebooks and kernels. ServerApp.preferred_dir is deprecated in jupyter-server 2.0. Use FileContentsManager.preferred_dir instead"
),
)

@default("preferred_dir")
Expand Down
Loading