Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typings for mypy 1.6 #1337

Merged
merged 1 commit into from
Oct 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
]

try:
import enchant # type:ignore[import] # noqa
import enchant # type:ignore[import-not-found] # noqa

extensions += ["sphinxcontrib.spelling"]
except ImportError:
Expand Down
2 changes: 1 addition & 1 deletion examples/identity/system_password/jupyter_server_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import pwd
from getpass import getuser

from pamela import PAMError, authenticate # type:ignore[import]
from pamela import PAMError, authenticate # type:ignore[import-not-found]

from jupyter_server.auth.identity import IdentityProvider, User

Expand Down
2 changes: 1 addition & 1 deletion examples/simple/simple_ext11/application.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"""A Jupyter Server example application."""
import os

from simple_ext1.application import SimpleApp1 # type:ignore[import]
from simple_ext1.application import SimpleApp1 # type:ignore[import-not-found]
from traitlets import Bool, Unicode, observe

from jupyter_server.serverapp import aliases, flags
Expand Down
2 changes: 1 addition & 1 deletion jupyter_server/gateway/managers.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from time import monotonic
from typing import Any, Dict, Optional

import websocket # type:ignore[import]
import websocket # type:ignore[import-untyped]
from jupyter_client.asynchronous.client import AsyncKernelClient
from jupyter_client.clientabc import KernelClientABC
from jupyter_client.kernelspec import KernelSpecManager
Expand Down
2 changes: 1 addition & 1 deletion jupyter_server/prometheus/metrics.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
# Jupyter Notebook also defines these metrics. Re-defining them results in a ValueError.
# Try to de-duplicate by using the ones in Notebook if available.
# See https://github.com/jupyter/jupyter_server/issues/209
from notebook.prometheus.metrics import ( # type:ignore[import]
from notebook.prometheus.metrics import ( # type:ignore[import-not-found]
HTTP_REQUEST_DURATION_SECONDS,
KERNEL_CURRENTLY_RUNNING_TOTAL,
TERMINAL_CURRENTLY_RUNNING_TOTAL,
Expand Down
2 changes: 1 addition & 1 deletion jupyter_server/services/sessions/sessionmanager.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
import sqlite3
except ImportError:
# fallback on pysqlite2 if Python was build without sqlite
from pysqlite2 import dbapi2 as sqlite3 # type:ignore[import,no-redef]
from pysqlite2 import dbapi2 as sqlite3 # type:ignore[import-not-found,no-redef]

from dataclasses import dataclass, fields

Expand Down
2 changes: 1 addition & 1 deletion jupyter_server/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
)
from urllib.request import pathname2url # noqa: F401

from _frozen_importlib_external import _NamespacePath # type:ignore[import]
from _frozen_importlib_external import _NamespacePath # type:ignore[import-not-found]
from jupyter_core.utils import ensure_async
from packaging.version import Version
from tornado.httpclient import AsyncHTTPClient, HTTPClient, HTTPRequest, HTTPResponse
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ nowarn = "test -W default {args}"

[tool.hatch.envs.typing]
features = ["test"]
dependencies = [ "mypy>=1.5.1", "traitlets>=5.11.2", "jupyter_core>=5.3.2"]
dependencies = [ "mypy~=1.6", "traitlets>=5.11.2", "jupyter_core>=5.3.2"]
[tool.hatch.envs.typing.scripts]
test = "mypy --install-types --non-interactive {args:.}"

Expand Down
2 changes: 1 addition & 1 deletion tests/test_terminal.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import warnings

import pytest
from flaky import flaky # type:ignore[import]
from flaky import flaky # type:ignore[import-untyped]
from tornado.httpclient import HTTPClientError
from traitlets.config import Config

Expand Down
Loading