New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't instantiate an unused Future in gateway connection trait #1276

Merged

blink1073 merged 1 commit into jupyter-server:main from minrk:gateway-connection-default

May 12, 2023

Contributor

minrk commented May 12, 2023

instantiating Future at import will often not work because no event loop is running


          Don't specify an unused Future

f43379c

instantiating Future at import will often not work because no event loop is running

blink1073 added the bug label

blink1073 approved these changes

View reviewed changes

Contributor

blink1073 left a comment

Thanks!

blink1073 merged commit cca1ef1 into jupyter-server:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug