Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extends the IP documentation #1258

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Conversation

hbcarlos
Copy link
Contributor

Extends the identity provider documentation.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes read fine to me. Thanks for adding this helpful detail @hbcarlos.

@kevin-bates
Copy link
Member

I'm hoping someone more familiar with identity providers than myself can also take a look. Thanks.

Copy link
Member

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @hbcarlos

@blink1073 blink1073 changed the title Extends the IP documentation Extends the IP documentation (#1258)Co-authored-by: Zachary Sailer <zachsailer@gmail.com> Apr 25, 2023
@blink1073 blink1073 merged commit 3ba9ac9 into jupyter-server:main Apr 25, 2023
@hbcarlos hbcarlos deleted the identity branch April 25, 2023 15:20
@krassowski
Copy link
Collaborator

@blink1073 fyi the title rename happened on merge. I guess this is due to new line in merge message getting lost sometimes?

@blink1073 blink1073 changed the title Extends the IP documentation (#1258)Co-authored-by: Zachary Sailer <zachsailer@gmail.com> Extends the IP documentation Apr 25, 2023
@blink1073
Copy link
Contributor

I fixed it, thanks @krassowski, it is an annoying default behavior that I just changed:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants