Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix priority of deprecated NotebookApp.notebook_dir behind ServerApp.root_dir (#1223 #1223

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Mar 2, 2023

The _root_dir_set flag prevents deprecated notebook_dir config from being loaded at a higher priority than newer root_dir config.

This config is relatively likely to be set, as notebook_shim means that legacy config, which should not be removed, is still loaded into ServerApp, so anyone who still has notebook config present for working with the older server will still get this config set on the new server, and it should be ignored in favor of newer config.

@minrk minrk added the bug label Mar 2, 2023
this flag prevents deprecated `notebook_dir` config from having higher priority than newer config
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07 🎉

Comparison is base (bc828c5) 80.38% compared to head (b7afe82) 80.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1223      +/-   ##
==========================================
+ Coverage   80.38%   80.45%   +0.07%     
==========================================
  Files          68       68              
  Lines        8249     8253       +4     
  Branches     1602     1603       +1     
==========================================
+ Hits         6631     6640       +9     
+ Misses       1196     1189       -7     
- Partials      422      424       +2     
Impacted Files Coverage Δ
jupyter_server/serverapp.py 80.56% <100.00%> (+0.51%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 changed the title fix priority of deprecated NotebookApp.notebook_dir behind ServerApp.root_dir Fix priority of deprecated NotebookApp.notebook_dir behind ServerApp.root_dir Mar 2, 2023
@blink1073 blink1073 changed the title Fix priority of deprecated NotebookApp.notebook_dir behind ServerApp.root_dir Fix priority of deprecated NotebookApp.notebook_dir behind ServerApp.root_dir (#1223 Mar 2, 2023
@blink1073 blink1073 merged commit 1dc3d58 into jupyter-server:main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants