Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #1193: Fix get_loader returning None when load_jupyter_server_extension is not found (#1193) (#1199)Co-authored-by: Steven Silvester <steven.silvester@ieee.org> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> #1199

Merged
merged 4 commits into from
Feb 3, 2023

Conversation

cmd-ntrf
Copy link
Contributor

@cmd-ntrf cmd-ntrf commented Feb 3, 2023

No description provided.

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 71.45% // Head: 71.53% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (2cde81a) compared to base (2ca8008).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.x    #1199      +/-   ##
==========================================
+ Coverage   71.45%   71.53%   +0.07%     
==========================================
  Files          62       62              
  Lines        7806     7809       +3     
  Branches     1543     1542       -1     
==========================================
+ Hits         5578     5586       +8     
+ Misses       1837     1832       -5     
  Partials      391      391              
Impacted Files Coverage Δ
jupyter_server/extension/utils.py 82.92% <100.00%> (+14.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 added the bug label Feb 3, 2023
@blink1073 blink1073 changed the title Backport PR #1193 to branch 1.x Backport PR #1193: Fix get_loader returning None when load_jupyter_server_extension is not found (#1193) Feb 3, 2023
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The failures are unrelated

@blink1073 blink1073 changed the title Backport PR #1193: Fix get_loader returning None when load_jupyter_server_extension is not found (#1193) Backport PR #1193: Fix get_loader returning None when load_jupyter_server_extension is not found (#1193) (#1199)Co-authored-by: Steven Silvester <steven.silvester@ieee.org> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Feb 3, 2023
@blink1073 blink1073 merged commit 8ab076e into jupyter-server:1.x Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants