-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable users to copy both files and directories #1190
Merged
blink1073
merged 13 commits into
jupyter-server:main
from
kenyaachon:copy-folder-functionality
Feb 24, 2023
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f890ef4
Enable users to copy both files and directories
57200e8
Fix issues for windows test for the test_copy_big_dir
7fc89fb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] aa8b252
Fix tests for macos platform
kenyaachon 80df337
Fix linting issues
kenyaachon d7520ed
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 8ab6fb5
add max_copy_folder_size_mb trait and adjust tests
kenyaachon 79a0192
fixup! add max_copy_folder_size_mb trait and adjust tests
kenyaachon 8f0bdf3
fixup! add max_copy_folder_size_mb trait and adjust tests
kenyaachon 6092b31
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] e5d65a1
remove old code that is commented out
kenyaachon f859307
Move the max_copy_folder_size_mb trait from ContentsManager to FileCo…
invalid-email-address 395842b
Merge branch 'main' into copy-folder-functionality
blink1073 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, perhaps this trait should be on
FileManager
, since it isn't implemented in the more genericContentsManager
. Anyone have any thoughts?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - I completely agree - good catch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will make sure to make that change @blink1073.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blink1073, when you say
FileManager
do you mean theFileContentsManager
or theLargeFileManager
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kenyaachon - yes,
FileContentsManager
is the appropriate location for the trait since it's the "most base" class for the file-based contents managers. Sorry for the confusion.