-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reapply preferred_dir fix, now with better backwards compatability #1162
Conversation
…rver#1140)" This reverts commit b5b7c5e.
This way, anyone that reads out the old value will not break (except if the path is not a FS path, in which case it doesn't currently work anyways).
Codecov ReportBase: 79.93% // Head: 79.88% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1162 +/- ##
==========================================
- Coverage 79.93% 79.88% -0.05%
==========================================
Files 68 68
Lines 8099 8124 +25
Branches 1599 1601 +2
==========================================
+ Hits 6474 6490 +16
- Misses 1202 1207 +5
- Partials 423 427 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
The check_release failure is addressed in #1163 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@meeseeksdev please backport to 1.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
…better backwards compatability
…ds compatability (#1167) Co-authored-by: Steven Silvester <steven.silvester@ieee.org>
This reverts #1140, reapplying #983. It then adds compatibility with jupyterlab_server prior to jupyterlab/jupyterlab_server#324, by writing back validated values to the serverapp's trait.