Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #1139 on branch 1.x (Raise errors on individual problematic extensions when listing extension) #1141

Merged

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #1139: Raise errors on individual problematic extensions when listing extension

@lumberbot-app lumberbot-app bot added the bug label Dec 19, 2022
@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Base: 71.43% // Head: 71.35% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (f89569b) compared to base (28c9e29).
Patch coverage: 45.45% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.x    #1141      +/-   ##
==========================================
- Coverage   71.43%   71.35%   -0.08%     
==========================================
  Files          62       62              
  Lines        7758     7765       +7     
  Branches     1536     1537       +1     
==========================================
- Hits         5542     5541       -1     
- Misses       1826     1835       +9     
+ Partials      390      389       -1     
Impacted Files Coverage Δ
jupyter_server/extension/serverextension.py 71.62% <45.45%> (-3.56%) ⬇️
jupyter_server/extension/manager.py 92.03% <0.00%> (-0.50%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 merged commit 8de93c8 into jupyter-server:1.x Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants