Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport PR #1095 on branch 1.x (Defer webbrowser import) #1097

Merged
merged 1 commit into from
Nov 25, 2022
Merged

Backport PR #1095 on branch 1.x (Defer webbrowser import) #1097

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion jupyter_server/serverapp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
import time
import urllib
import warnings
import webbrowser
from base64 import encodebytes

try:
Expand Down Expand Up @@ -2689,6 +2688,10 @@ def _prepare_browser_open(self):
return assembled_url, open_file

def launch_browser(self):
# Deferred import for environments that do not have
# the webbrowser module.
import webbrowser

try:
browser = webbrowser.get(self.browser or None)
except webbrowser.Error as e:
Expand Down