Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jp_ws_fetch not work by its own #441

Closed
eastonsuo opened this issue Mar 9, 2021 · 3 comments
Closed

jp_ws_fetch not work by its own #441

eastonsuo opened this issue Mar 9, 2021 · 3 comments

Comments

@eastonsuo
Copy link
Contributor

eastonsuo commented Mar 9, 2021

instead of
async def my_test(jp_ws_fetch):
I must use
async def my_test(jp_ws_fetch, http_server_client) or
async def my_test(jp_fetch, jp_ws_fetch) to run ws_fetch correctly, which may confuse me when I only want to test websocet

@Zsailer
Copy link
Member

Zsailer commented May 25, 2021

Thanks, @pumpkindle! Good catch.

Looks like a simple fix. Would you like to submit a PR to fix this?

@eastonsuo
Copy link
Contributor Author

thx for reply, I'll have a try

blink1073 pushed a commit that referenced this issue May 26, 2021
Co-authored-by: yi suo <pumpkinday2012@gmail.com>
@Zsailer
Copy link
Member

Zsailer commented May 27, 2021

Thanks, @pumpkindle! Fixed in #527.

@Zsailer Zsailer closed this as completed May 27, 2021
Zsailer pushed a commit that referenced this issue Jun 17, 2021
* fix jp_ws_fetch not work by its own #441

* add a method for create a task immediately after io_loop is ready

* create io_loop earlier to solve 'enable a way to run a task when an io_loop is created #531'

Co-authored-by: yi suo <pumpkinday2012@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants