Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in cookie secret filename #366

Closed
jasongrout opened this issue Dec 24, 2020 · 0 comments · Fixed by #367
Closed

Typo in cookie secret filename #366

jasongrout opened this issue Dec 24, 2020 · 0 comments · Fixed by #367
Labels
good first issue

Comments

@jasongrout
Copy link
Contributor

As pointed out by @michaelaye at https://gitter.im/jupyterlab/jupyterlab?at=5fe4ebec4eba353cdff8c39f:

Just trying out the conda version. first thing i see: Our favorite kernel_spec_manager_class warning is there twice now, and I'm wondering if the cookie filename is a typo or done on purpose?
Writing notebook server cookie secret to /home/maye/.local/share/jupyter/runtime/jupytr_cookie_secret

The typo is here:

jupyter_server/jupyter_server/serverapp.py

Line 702 in 4e4ab20

return os.path.join(self.runtime_dir, 'jupytr_cookie_secret')

@michaelaye michaelaye mentioned this issue Dec 24, 2020
Merged
Zsailer added a commit to Zsailer/jupyter_server that referenced this issue Nov 18, 2022
@Zsailer
Consistent handling/emitting of kernel session state (jupyter-server#366
67e713c 
)

* update state

* streamline events about sessions

* compute a kernel path server-side and emit that in event data

* rename some modules

* code review cleanup

* define kernel states as constants for easier future maintenance

* fix broken unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update serverapp.py michaelaye/jupyter_server
1 participant
@jasongrout