Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to do with classic HTML templates #16

Closed
SylvainCorlay opened this issue Jul 28, 2018 · 5 comments
Closed

What to do with classic HTML templates #16

SylvainCorlay opened this issue Jul 28, 2018 · 5 comments

Comments

@SylvainCorlay
Copy link
Contributor

We have kept the HTML templates from the classic notebook server.

I guess that 404.html and error.html and their bases belong to the server. What about the other ones?

@minrk
Copy link
Contributor

minrk commented Sep 17, 2018

Most should probably go away. 404/error rely on page.html for the basic layout. This is really part of the notebook application, though, not necessarily shared by everything.

An argument could be made that the pure server doesn't have pages, even errors, and those are provided by extensions, and the default server should have only super-minimal error pages by default.

@Zsailer
Copy link
Member

Zsailer commented Jun 6, 2019

We removed most of the templates in #54. We've included a minimal error page and main landing page for the server.

The main question I have is, what do we do with templates+handlers for terminals, nbconvert, editor, etc.? The notebook client includes templates, js, and css for these APIs, but the server includes the backend APIs. Should we always require that extensions provide their own frontend to these APIs?

@Zsailer
Copy link
Member

Zsailer commented Jun 6, 2019

This might indicate that those APIs should be made into server extensions and remain separate from the server. The server only comes with the pieces in the services submodule.

@vidartf
Copy link
Member

vidartf commented Aug 28, 2019

I see that the login/logout templates were removed, but the corresponding handlers are still a part of the server. What is the intended way of operation here? The auth logic should ideally be shared between different Jupyter apps on the same system, so I would argue for keeping some sane minimum implementation. Alternatively, I would prefer to keep at least an extensible template base.

@Zsailer Zsailer added this to the 0.2.0 Release milestone Dec 2, 2019
@Zsailer
Copy link
Member

Zsailer commented Dec 2, 2019

@vidartf, I agree. I actually opened an #85 to discuss this. Closing this issue in favor of #85 to focus discussion on login/logout.

@Zsailer Zsailer closed this as completed Dec 2, 2019
Zsailer pushed a commit to Zsailer/jupyter_server that referenced this issue Nov 18, 2022
asyncify provisioner and notebook service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants