Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.0rc8: useless npm install & npm run build if built from sdist #1107

Closed
frenzymadness opened this issue Dec 1, 2022 · 1 comment · Fixed by #1108
Closed

2.0.0rc8: useless npm install & npm run build if built from sdist #1107

frenzymadness opened this issue Dec 1, 2022 · 1 comment · Fixed by #1108
Labels

Comments

@frenzymadness
Copy link
Contributor

When I run a build on top of the sources downloaded from PyPI (sdist) the build process depends on npm and runs npm install and npm run build which downloads 41 nodejs modules from internet. I believe this is unnecessary because it literally changes nothing in the source tree as the minimal CSS files are already present in the sdist.

Would it be possible to skip this step if the artifacts it should create already exist?

@welcome
Copy link

welcome bot commented Dec 1, 2022

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant