Skip to content

Commit

Permalink
fix terminal test on Windows
Browse files Browse the repository at this point in the history
  • Loading branch information
vidartf committed Nov 25, 2022
1 parent a50dd7c commit 5280377
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion tests/test_terminal.py
Original file line number Diff line number Diff line change
Expand Up @@ -276,4 +276,10 @@ def test_shell_command_override(
pytest.importorskip("traitlets", minversion=min_traitlets)
argv = shlex.split(f"--ServerApp.terminado_settings={terminado_settings}")
app = jp_configurable_serverapp(argv=argv)
assert app.web_app.settings["terminal_manager"].shell_command == expected_shell
if os.name == "nt":
assert app.web_app.settings["terminal_manager"].shell_command in (
expected_shell,
" ".join(expected_shell),
)
else:
assert app.web_app.settings["terminal_manager"].shell_command == expected_shell

0 comments on commit 5280377

Please sign in to comment.