Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore package pytest config #246

Merged
merged 1 commit into from
Jan 20, 2022
Merged

ignore package pytest config #246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions jupyter_releaser/lib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ def check_links(ignore_glob, ignore_links, cache_file, links_expire):
cmd += f"--check-links-cache-name {cache_dir}/check-release-links "
# do not run doctests, since they might depend on other state.
cmd += "-p no:doctest "
# ignore package pytest configuration,
# since we aren't running their tests
cmd += "-c _IGNORE_CONFIG"
Copy link
Contributor Author

@minrk minrk Jan 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a special value for pytest; pytest has no option I could find to skip loading config files, so this is a filename that probably won't exist, so no config will be found.

It could also be done to put the check-links pytest config in a config file in this package, and use that to override the package's config.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think since the config is dynamic we should write out a temporary config file, echo it for debugging, and then use it during each run. This is a reasonable workaround for now, thanks!


ignored = []
for spec in ignore_glob:
Expand Down