Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define _jupyter_server_extension_paths for backward compatibility #134

Closed
wants to merge 4 commits into from
Closed

Conversation

casparvl
Copy link

@casparvl casparvl commented Jul 8, 2022

Also, the __init__.py file used to contain

load_jupyter_server_extension = load_jupyter_server_extension

That doesn't seem to make sense, it's like x = x, that's a no-op. Probably you meant to do what was suggested here https://jupyter-server.readthedocs.io/en/latest/developers/extensions.html#migrating-an-extension-to-use-jupyter-server , also for backward compatibility.

For comparison, see e.g. https://github.com/jupyterhub/jupyter-server-proxy/blob/099fce21feed4c5c762740dea2d34c5ca548c5b3/jupyter_server_proxy/__init__.py#L51

@welcome
Copy link

welcome bot commented Jul 8, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@casparvl
Copy link
Author

Ping on this one: is there anything blocking the merge of this fix?

@jtpio
Copy link
Member

jtpio commented Sep 30, 2022

Thanks @casparvl this looks good 👍

Waiting for the CI fix to complete in #145. We can then rebase this PR and merge it.

@casparvl casparvl closed this by deleting the head repository Sep 30, 2022
@casparvl casparvl reopened this Sep 30, 2022
@casparvl
Copy link
Author

casparvl commented Oct 4, 2022

@jtpio I accidentally removed my fork for this. I saw you rebased my other PR based on #145 . Can you still do the same for thise one so that it can be merged? Or is that impossible now that more fork disappeared? If the 2nd: any suggestion on how we best proceed? It's a one-line change, if needed I can recreate it in a new fork (or you can, whichever you prefer)...

@jtpio
Copy link
Member

jtpio commented Oct 4, 2022

@casparvl maybe the best would be to create a new branch on your fork with this change, and open a new PR.

@casparvl
Copy link
Author

casparvl commented Oct 4, 2022

Closing in favour of #148

@casparvl casparvl closed this Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants