Allow users to opt out of prometheus metrics

[dleen]

Poor mans fix for #123

[welcome]

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.

You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[kevin-bates]

Thanks @dleen - this LGTM and addresses an issue that multiple consumers are running into.

My only suggestion would be that it might be helpful to indicate at runtime (via a log message, DEBUG or INFO) that Prometheus metric collection has been disabled, but I'd be fine releasing without the messaging as well.

[dleen]

@kevin-bates good suggestion! done!

[kevin-bates]

Hi @jtpio - I'm hoping you might be able to give this PR some attention relative to its review/merge/release as it will alleviate some heartburn for others.

In looking into this, I found that the lint tooling must have changed over (I'm assuming) its last major release and have provided PR #138 to address the linting failures evident on the various PRs - so it might be helpful to review/merge that PR prior to others.

I you need help, or I should be reaching out to someone else, please let me know. Thank you.

[jtpio]

Thanks @kevin-bates for the ping, this looks good.

I used the GitHub button to rebase the branch to make sure to grab the fixes from #138:

Also this repo is compatible with the Jupyter Releaser so we can make a 0.6.2 release after merging this.

Actually @kevin-bates if you would like to make the release feel free to proceed. You should have publish access to PyPI already. And I can add you to npm if you give me your username (the JupyterLab extension is also published to npm for consistency): https://www.npmjs.com/package/@jupyter-server/resource-usage

[welcome]

Congrats on your first merged pull request in this project! 🎉

Thank you for contributing, we are very proud of you! ❤️

[kevin-bates]

Hi @jtpio. I'm sorry, I don't currently have the bandwidth to revisit the jupyter-releaser stuff (I've used it once, probably late last year) and wouldn't want to mess things up. If you're unable to get to this in the next couple of days, I could probably spend some time with it on Friday. FWIW, my npm username is kbates.