Updated to latest version of jupyterlab-blockly
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbcarlos
reviewed
Sep 6, 2022
Comment on lines
+90
to
+100
| "outputDir": "jupyterlab_niryo_one/labextension", | ||
| "sharedPackages": { | ||
| "jupyterlab-blockly": { | ||
| "bundled": false, | ||
| "singleton": true | ||
| }, | ||
| "blockly": { | ||
| "bundled": false, | ||
| "singleton": true | ||
| } | ||
| } |
There was a problem hiding this comment.
@DenisaCG We need to revert this change. I believe this is the reason why we are seeing the error Uncaught Error: Language "Python" does not know how to generate code for block type "niryo_one_connect"..
This configuration should be present only in the extension that export the plugin.
There was a problem hiding this comment.
Line 90 it's ok. We need to remove the sharedPackages attribute.
There was a problem hiding this comment.
@hbcarlos Isn't this a case of requiring a service and as such following under the sharedPackages configuration detailed here in the documentation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.