Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests and edge cases in jump to, diagnostics, highlighting, and rename #966

Merged
merged 22 commits into from
Aug 29, 2023
Merged

Fix tests and edge cases in jump to, diagnostics, highlighting, and rename #966

merged 22 commits into from
Aug 29, 2023

Commits on Aug 27, 2023

  1. Fix jump to in notebooks, fix diagnostics and jump tests

    @krassowski
    krassowski committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    1a679c9 View commit details
    Browse the repository at this point in the history

  2. Fix context when executed over non-active cell for hover, rename and … 

    …jump to
    @krassowski
    krassowski committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    15267fa View commit details
    Browse the repository at this point in the history

  3. Fix tags

    @krassowski
    krassowski committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    7f32a6a View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Fix syntax highlighting test

    @krassowski
    krassowski committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    e60e196 View commit details
    Browse the repository at this point in the history

  2. Fix jump test

    @krassowski
    krassowski committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    daef0f3 View commit details
    Browse the repository at this point in the history

  3. Apply syntax highlighting on start, fix highlight restoration

    @krassowski
    krassowski committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    12ec067 View commit details
    Browse the repository at this point in the history

  4. Remove duplicated context assembler in jump to

    @krassowski
    krassowski committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    e500b57 View commit details
    Browse the repository at this point in the history

  5. Fix index for skipInspect retrieval

    @krassowski
    krassowski committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    54dac9a View commit details
    Browse the repository at this point in the history

  6. List visible diagnostics when wait fails to aid debugging

    @krassowski
    krassowski committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    c3f6fd1 View commit details
    Browse the repository at this point in the history

  7. Remove unused CSS rule

    @krassowski
    krassowski committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    afff861 View commit details
    Browse the repository at this point in the history

  8. Fix removing highlights on blur

    @krassowski
    krassowski committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    88819ba View commit details
    Browse the repository at this point in the history

  9. Update selector for highlights in tests

    @krassowski
    krassowski committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    7e899d2 View commit details
    Browse the repository at this point in the history

  10. Use the new diagnostic wait to fix configuration tests

    @krassowski
    krassowski committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    0baa449 View commit details
    Browse the repository at this point in the history

  11. Improve (and test) implementation of signature attributes marking 

    - enh: class names will be applied on marks as needed
- perf: empty marks won't be added
- perf: elements wont be created if not needed
    @krassowski
    krassowski committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    1763d75 View commit details
    Browse the repository at this point in the history

  12. Correct fix for diagnostics silencing (the offset was ok), see: 

    jupyterlab/jupyterlab#15034
    @krassowski
    krassowski committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    412d849 View commit details
    Browse the repository at this point in the history

  13. Attempt to re-enabled diagnostics in foreign test (failed)

    @krassowski
    krassowski committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    f4b554d View commit details
    Browse the repository at this point in the history

  14. Fix expectations in syntax highlighting tests

    @krassowski
    krassowski committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    0c5196d View commit details
    Browse the repository at this point in the history

  15. Fix configuration

    @krassowski
    krassowski committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    04c5859 View commit details
    Browse the repository at this point in the history

  16. Try to target more specific part (although spans are not guaranteed)

    @krassowski
    krassowski committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    5329958 View commit details
    Browse the repository at this point in the history

  17. Try text node selectors

    @krassowski
    krassowski committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    f3d75c0 View commit details
    Browse the repository at this point in the history

  18. Use upstream FormComponent (hides submit button among others)

    @krassowski
    krassowski committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    e495af8 View commit details
    Browse the repository at this point in the history

  19. Improve/lint diagnostics.py

    @krassowski
    krassowski committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    38e7b80 View commit details
    Browse the repository at this point in the history