Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve: kernel completions in R, completions in strings and paths #686

Merged
merged 4 commits into from
Oct 10, 2021

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Oct 10, 2021

References

Fixes #667 and fixes #639.

Code changes

  • fix kernel completions not showing up for R due to lettercase difference in identifiers
  • fix tab completions not showing up in strings due to incomplete trigger kind invalidation
  • fix path completions reconciliation for pyls/pylsp with IPython by working around different prefixes returned by LSP and kernel as a special case

User-facing changes

Backwards-incompatible changes

None

Chores

  • linted
  • tested
  • documented
  • changelog entry

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch jupyter-lsp/jupyterlab-lsp/completion-fixes

@krassowski krassowski changed the title Improve completion: kernel completions in R, completion in strings and paths Improve: kernel completions in R, completions in strings and paths Oct 10, 2021
@krassowski krassowski merged commit 8c9b01b into master Oct 10, 2021
@krassowski krassowski deleted the completion-fixes branch October 10, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path completion broken autocompletion suggest from IRKernel disappeared after r languageserver enabled
1 participant