Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only search for label match if different from insertText match #523

Merged
merged 2 commits into from
Feb 14, 2021
Merged

Only search for label match if different from insertText match #523

merged 2 commits into from
Feb 14, 2021

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Feb 14, 2021 •
edited
Loading

Only search for label match if different from insertText match and escape HTML label when no query is used.

References

Follow-up after #520

Code changes

  • avoid matching again if the label prefix and insertText are the same
  • escape HTML in label if no query is passed (so it is not removed by sanitizer)

User-facing changes

  • better filtering performance while retaining the benefit of using server-provided insertText
  • completion of HTML/XML etc should work consistently

Backwards-incompatible changes

None

Chores

  • linted
  • tested
  • documented
  • changelog entry

@krassowski krassowski merged commit c3e90ec into master Feb 14, 2021
@krassowski krassowski deleted the completion/smarter-use-of-sum-of-squares branch February 16, 2021 23:22
@krassowski krassowski added this to the 3.4 milestone Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
1 participant
@krassowski