Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] [squash] Add conda locks for CI #348

Closed
wants to merge 67 commits into from

Conversation

bollwyvl
Copy link
Collaborator

@bollwyvl bollwyvl commented Sep 10, 2020

References

Code changes

  • adds conda-lock
    • checked in locks for all current CI excursions
    • lock.py is implemented as a dodo task generator
      • could be extended in the future to capture more of the workflow, from checkout to release
  • using the locked env above (as show in the docs), ran the new black

Anecdata:

  • absolute best case (cold cache on master, hot cache on the PR)

lint: linux py38

branch conda cache conda env yarn cache yarn total
master 0:00 3:08 1:54 0:00 1:05 9:33
pr 0:10 1:49 0:24 0:02 1:52 5:59
pr (run2) 0:06 1:31 0:25 0:01 1:58 5:46

test: win-64 py3.8

branch conda cache conda env yarn cache yarn total
master 0:00 7:38 0:00 0:00 3:36 50:17
pr TODO 0:00 0:52 5:52 0:04 0:00 ?:??
  • the yarn thing is troubling...

will update with a better windows benchmark set

User-facing changes

N/A

Backwards-incompatible changes

N/A

Chores

  • linted
  • tested
  • documented
  • changelog entry

@krassowski
Copy link
Member

Btw before adding conda cache, conda was about 2:50, so it feels like download of packages was not a bottleneck. I even wondered if having local packages could result in slower times to solve the env., but then I was not using mamba yet (and the lock files were already on horizon).

@bollwyvl bollwyvl reopened this Sep 13, 2020
@bollwyvl bollwyvl closed this Sep 13, 2020
@bollwyvl bollwyvl reopened this Sep 13, 2020
@bollwyvl bollwyvl closed this Sep 17, 2020
@bollwyvl bollwyvl reopened this Sep 17, 2020
@bollwyvl bollwyvl closed this Sep 18, 2020
@bollwyvl bollwyvl reopened this Sep 18, 2020
@bollwyvl
Copy link
Collaborator Author

Ha, finally got a cache hit on windows for the conda packages. Now to see if it makes a lick of difference...

@bollwyvl
Copy link
Collaborator Author

Haven't dug into the repeated TabError fail (first on osx, then on win), but otherwise starting to look good.

I've also warmed back up the setup-miniconda PR which would directly support the lock files:

conda-incubator/setup-miniconda#74

@bollwyvl bollwyvl closed this Oct 6, 2020
@bollwyvl bollwyvl reopened this Oct 6, 2020
@krassowski
Copy link
Member

Stale?

@bollwyvl
Copy link
Collaborator Author

bollwyvl commented Jan 9, 2021 via email

@bollwyvl
Copy link
Collaborator Author

bollwyvl commented Jan 9, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants