-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.0 release plan #917
Comments
Is there a timeline for jupyterlab-lsp 5.0 release? |
There is no timeline yet - it may depend on community contributions. |
Jupyterlab V4.0.2 is released. Looking forward to V4 support. |
Could you prioritize " switch to JupyterLab's 4.0 @jupyterlab/lsp package", maybe add other features as time permits? |
I am working on JupyterLab 4.0 support; it requires a substantial rewrite due to a different editor (CodeMirror 6), the |
First pre-release supporting JupyterLab 4.0 is now available: |
First beta is out: v5.0.0b0. Please report any bugs you see, this will help accelerate the final release. |
Have started conda-forge/jupyter-lsp-feedstock#50, which would be installable from mamba install -c conda-forge -c conda-forge/label/jupyter_lsp_beta "jupyterlab-lsp==5.0.0b0"
Some packaging thoughts:
|
Also, perhaps an npm |
Tried kicking all the future tires with this gist on binder. I had the jupyterlab 4.1.0 alpha in there, but it didn't like it:
At least during the pre-release cycle, we should probably allow that case... |
Lots of other weirdness underway... maybe we try to carve out some time after the wednesday call to take a look at some things. |
This is because of jupyterlab-lsp/packages/jupyterlab-lsp/package.json Lines 150 to 156 in 98a8794
I will disable it for 5.0.0b1. |
this will need bumping version and somewhat stabilising APIs. I am still somewhat tempted to break up features into packages but it is becoming increasingly less likely without resources and with other more pressing deadlines. Anyways, once the completer issues are fixed upstream (and if there are no further issues found in beta1) I think we can publish an RC with npm packages. |
Once #978 is in, the only remaining blocker for RC will be upstream JupyterLab completer work, which had 1 PR merged, 1 in review, and 1 in the works; if we are lucky this could happen in the upcoming week. This is was the most difficult version transition so far, with many things subtly breaking due to the way the core LSP was merged into JupyterLab. I am glad this is nearly over. |
Is it possible to install 5.0.0b1 (or any other pre-release) from repo itself? pip still have only released version. Thanks. |
No, it does not: https://pypi.org/project/jupyterlab-lsp/5.0.0b1/ use |
Also available on mamba install -c conda-forge/label/jupyter_lsp_beta -c conda-forge jupyterlab-lsp
# stuff happens ...
# + jupyterlab-lsp 5.0.0b0 pyhe83ca6f_0 conda-forge/label/jupyter_lsp_beta/noarch 568kB |
Release candidate is up:
If nothing major comes up I will publish the final release one week from this moment. |
Note: a release blocker has been identified (crash of the browser on editing of large notebooks with magic transculsions, like
There may be a way to workaround it in jupyterlab-lsp by rewriting the update manager, but this defeats the purpose of migrating the code upstream for easier reuse, so ideally the fix would be applied upstream too. The best course of action would probably be developing a fix here and then applying it upstream for 4.1 release as it would likely extend API surface. This might take more time. CC @hbcarlos (for awareness). Alternatively, we could release 5.0 with transculsions disabled by default. This would lead to worse UX but should avoid the crashes. What do you all think? |
I've been using the rc for some time and works like a charm, maybe disable transculsions (what a word 😄)? But I'm not a user of those, so I don't have the complete picture |
Since fixing magic transclusions is expected to take some time, I would advocate releasing 5.0 with magic transclusions turned off, and putting it on known regressions and 5.1/5.2 to-do lists. If the jupyterlab-lsp API is expected to be affected by this work (not sure if it will be), maybe put a warning in the docs that this area is WIP (although this may not be critical since the rest of the API docs may not have been updated per #962 anyway). |
We will put resources towards fixing this in the next couple of weeks, hopefully fixing the last outstanding issues. |
Thank you so much @SylvainCorlay! Collaborating with your team on bringing this upstream is amazing and I am grateful for open communication.
I applied a workaround in the extension by force-overwriting a private method from upstream ( |
v5.0.0 is now available on npm and PyPI. Thank you all for testing and support! |
also from |
This is the current plan for 5.0 release:
@jupyterlab/lsp
packageAs per feedback, remaining items were moved to 5.1 release plan
The text was updated successfully, but these errors were encountered: