You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
connect_completion(){// see https://github.com/jupyterlab/jupyterlab/blob/c0e9eb94668832d1208ad3b00a9791ef181eca4c/packages/completer-extension/src/index.ts#L198-L213constcell=this.widget.content.activeCell;this.set_completion_connector(cell);consthandler=this.completion_manager.register({connector: this.current_completion_connector,editor: cell.editor,parent: this.widget});this.widget.content.activeCellChanged.connect((notebook,cell)=>{this.set_completion_connector(cell);handler.editor=cell.editor;handler.connector=this.current_completion_connector;});}
The JupyterLab project's naming convention is CamelCase, eg.this.widget.content.activeCellChanged, it looks better if the extension code use the same naming convention.
The text was updated successfully, but these errors were encountered:
Yes, it is planned, but this is low priority. I find the snake case easier to read and therefore used it for the extension at the prototyping phase; moreover, it allowed me to easily distinguish the code from the extension itself and classes extended by inheritance. As we are mostly past prototyping phase and most of the code is no longer inheriting from our dependencies I welcome the change, but I will postpone it to reduce merge conflicts.
I see codes like:
The JupyterLab project's naming convention is CamelCase, eg.
this.widget.content.activeCellChanged
, it looks better if the extension code use the same naming convention.The text was updated successfully, but these errors were encountered: