Skip to content
This repository has been archived by the owner on Oct 26, 2019. It is now read-only.

Option to support https #3

Closed
parente opened this issue Dec 8, 2015 · 6 comments
Closed

Option to support https #3

parente opened this issue Dec 8, 2015 · 6 comments
Assignees
Milestone

Comments

@parente
Copy link
Member

parente commented Dec 8, 2015

Allow specification of the key and cert via nconf supported parameters.

@parente parente modified the milestone: 0.1.0 Jan 18, 2016
@parente parente assigned poplav and jhpedemonte and unassigned poplav and jhpedemonte Jan 18, 2016
@poplav
Copy link
Contributor

poplav commented Jan 18, 2016

Pull Request #14 should resolve this issue.

@jhpedemonte
Copy link
Collaborator

Merged @poplav's PR. One addition that would be nice: when loading HTTP, I get an error. Would be better to just redirect to HTTPS.

@parente
Copy link
Member Author

parente commented Jan 21, 2016

Redirect +1.

@poplav
Copy link
Contributor

poplav commented Jan 21, 2016

@jhpedemonte , #16 creates an http server along with the https server. When a request goes to the http server the url location is set to point to the https server.

@parente
Copy link
Member Author

parente commented Jan 25, 2016

Rebased this AM. Decided in a chat that, for now, the Docker internal ports must match the Docker external ports to let the redirect only require two env vars instead of three (with the third being the external redirect port if we allowed arbitrary Docker mappings.) We can revisit more config later.

@parente
Copy link
Member Author

parente commented Jan 25, 2016

Merged in PR #16.

@parente parente closed this as completed Jan 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants