Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add build-time execution #856
feat: add build-time execution #856
Changes from all commits
c7089dc
b15ef1b
02b13b6
bc48dea
b2e6bba
3b8dc42
2962807
8b19f2a
072cb61
e87ee85
fa121d7
0c87b89
b18370e
f57198c
18b0702
2f121af
d2e38f8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Check warning on line 79 in packages/myst-cli/src/process/mdast.ts
GitHub Actions / lint
Check warning on line 80 in packages/myst-cli/src/process/mdast.ts
GitHub Actions / lint
Check warning on line 81 in packages/myst-cli/src/process/mdast.ts
GitHub Actions / lint
Check failure on line 23 in packages/myst-cli/src/process/notebook.ts
GitHub Actions / lint
Check failure on line 23 in packages/myst-cli/src/session/session.ts
GitHub Actions / lint
Check failure on line 174 in packages/myst-cli/src/session/session.ts
GitHub Actions / lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
await manager.ready
in turn does await thekernelManager.ready
if that's what you meanThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
callers of this function would need to know to
await (await jupyterSessionManager()).ready
unless you awaitmanager.ready
in here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this instance it's that there's no logic to avoid creating two managers if one doesn't properly await the promise to
session.jupyterSessionManager()
. i.e., between the first await and finally settingthis._jupyterSessionManager
.Check failure on line 11 in packages/myst-cli/src/session/types.ts
GitHub Actions / lint